[enh] Don't add Strict-Transport-Security header in nginx conf if using a selfsigned cert #661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
c.f. YunoHost/issues#1310 , Firefox and probably all decent browser ignore this header anyway
Solution
Don't add the header if using a self-signed cert
PR Status
Tested on my machine™
How to test
Pull the branch, have a domain with self-signed certificate, regen nginx conf. Check a javascript console before and after on the SSO portal.
Validation